You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current JS examples cannot be copied into an editor. Most systems use double or single quotes for imports, not backticks. There was also a missing "const" in one of the examples
Description
Related issues
Release Summary
Improve code examples for App Check.
Checklist
I read the Contributor Guide and followed the process outlined there for submitting PRs.
Yes
My change supports the following platforms;
Android
iOS
Other (macOS, web)
My change includes tests;
e2e tests added or updated in packages/\*\*/e2e
jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
Yes
No
Test Plan
Think react-native-firebase is great? Please consider supporting the project with any of the below:
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. 1 out of 2 committers have signed the CLA.
✅ mikehardy ❌ tj-mc You have signed the CLA already but the status is still pending? Let us recheck it.
I pushed a commit with the fix for prettier - just some spacing and single-ticks vs double-ticks. Not backticks though :)
That should also prompt CLA bot to recheck, I'm not sure - that is not working well on another PR also
The current JS examples cannot be copied into an editor. Most systems use double or single quotes for imports, not backticks. There was also a missing "const" in one of the examples
our settings for prettier strongly prefer the single-tick apparently
definitely not backticks though...
also there appears to have been some issue on main, but this fixes that
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current JS examples cannot be copied into an editor. Most systems use double or single quotes for imports, not backticks. There was also a missing "const" in one of the examples
Description
Related issues
Release Summary
Improve code examples for App Check.
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter