-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(docs): add a necessary await operator to the example code for initializeAppCheck() #8569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! 👋 thanks for this - could you sign the CLA? It's a small change but I can't merge with out it 😄
Thanks for the mention that the CONTRIBUTING doc was 404 in the PR template - was a problem with pathing not being as expected when the template was actually in use, vs just being examine in the file tree |
@mikehardy done |
This will conflict with another PR about to go in but I'll do the fixup and get this one in after |
…tializeAppCheck()
Fixed conflict after a rebase to main, will merge pending CI |
Something else, the link to the Contributor Guide that is in the template when you create a pull request gives a 404: Contributor Guide
https://github.com/invertase/react-native-firebase/CONTRIBUTING.md