Skip to content

fix(docs): add a necessary await operator to the example code for initializeAppCheck() #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

aike19115
Copy link
Contributor

@aike19115 aike19115 commented Jun 13, 2025

Something else, the link to the Contributor Guide that is in the template when you create a pull request gives a 404: Contributor Guide

https://github.com/invertase/react-native-firebase/CONTRIBUTING.md

Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 5:22pm

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2025

CLA assistant check
All committers have signed the CLA.

@aike19115 aike19115 changed the title fix(docs): add a necessary await operator to the example code fix(docs): add a necessary await operator to the example code for initializeAppCheck() Jun 13, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 thanks for this - could you sign the CLA? It's a small change but I can't merge with out it 😄

@mikehardy
Copy link
Collaborator

Thanks for the mention that the CONTRIBUTING doc was 404 in the PR template - was a problem with pathing not being as expected when the template was actually in use, vs just being examine in the file tree

b778210

@aike19115
Copy link
Contributor Author

@mikehardy done

@mikehardy
Copy link
Collaborator

This will conflict with another PR about to go in but I'll do the fixup and get this one in after

…tializeAppCheck()
@mikehardy
Copy link
Collaborator

Fixed conflict after a rebase to main, will merge pending CI

@mikehardy mikehardy merged commit a3cc4de into invertase:main Jun 30, 2025
7 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants