Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pixi lock files as generated #7111

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

freundTech
Copy link
Contributor

@freundTech freundTech commented Oct 28, 2024

Closes #7108
Pixi is a cross-platform package manager for the conda ecosystem. It uses a lockfile called pixi.lock, which should be counted as generated code.

Description

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

Pixi is a cross-platform package manager for the conda ecosystem.
It uses a lockfile called pixi.lock, which should be counted as
generated code.
@freundTech freundTech requested a review from a team as a code owner October 28, 2024 10:11
@spenserblack
Copy link
Contributor

spenserblack commented Oct 30, 2024

Might want to check on this and make sure this is OK with the Pixi maintainers: prefix-dev/pixi#265 (comment)

@freundTech
Copy link
Contributor Author

Might want to check on this and make sure this is OK with the Pixi maintainers: prefix-dev/pixi#265 (comment)

This PR and Issue #7108 have both been posted to the pixi discord server: https://discord.com/channels/1082332781146800168/1300274825838854235
While they haven't been explicitly approved by the pixi team they have been acknowledged.

Also the PR you linked is no longer up-to-date. As of prefix-dev/pixi#1488 pixi also adds linguist-generated to the .gitattributes file when initializing a project.

I also believe the answer in the PR you linked was given based on a misunderstanding:

I think it is very important people are aware a lock file changed in a PR.

Marking a file as generated doesn't hide that it changed in a PR. It just collapses it (just like large files are collapsed automatically). You can see that it changed, but you have to click to see what has changed.

@spenserblack
Copy link
Contributor

Sorry if my comment came off as argumentative 🙂
I just wanted to bring that up because it reminded me of when the yarn maintainer asked that yarn.lock should not be generated.

@lildude lildude added this pull request to the merge queue Nov 25, 2024
Merged via the queue into github-linguist:main with commit 6b31ca7 Nov 25, 2024
5 checks passed
@freundTech freundTech deleted the handle-pixi-lock branch November 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude Pixi.lock as generated
3 participants