Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update default pixi gitignore and gitattributes #1488

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Jun 8, 2024

With .pixi/config.toml being a valid configuration place, what do you think about excluding it from .gitignore?

Also, with pixi.lock file diffs getting very large, especially with multi-envs, I think it makes sense to add linguist-generated=true (in some cases, github refused to render the markdown anyway). https://github.com/pavelzw/pixi-diff-to-markdown can generate a bit prettier diffs anyway.

Maybe it makes sense to have a diff mode pixi diff pixi.lock.old pixi.lock.new as well that generates the same json output as pixi update --json and allow people to configure their git diff to use pixi similar to how bun does it.

@ruben-arts
Copy link
Contributor

The diff thing is awesome!

@pavelzw pavelzw requested a review from ruben-arts June 10, 2024 08:49
@ruben-arts ruben-arts enabled auto-merge (squash) June 10, 2024 09:58
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pavel

@ruben-arts ruben-arts merged commit 0889c8e into prefix-dev:main Jun 10, 2024
24 checks passed
@pavelzw pavelzw deleted the gitignore-gitattributes branch August 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants