Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Use quoted env for the version argument
To avoid invalid expansions into arbitrary commands
  • Loading branch information
franky47 committed Aug 31, 2025
commit b2f1959b79965b518b021be84ffd1c6e47fd0d25
3 changes: 2 additions & 1 deletion .github/workflows/analyse-nextjs-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ jobs:
- name: Install dependencies
run: pnpm install
- name: Check for changes in app router
run: ./next-release-analyser.mjs --version ${{ inputs.version }}
run: ./next-release-analyser.mjs --version "${{ env.VERSION }}"
working-directory: packages/scripts
env:
VERSION: ${{ inputs.version }}
MAILPACE_API_TOKEN: ${{ secrets.MAILPACE_API_TOKEN }}
EMAIL_ADDRESS_TO: ${{ secrets.EMAIL_ADDRESS_TO }}
EMAIL_ADDRESS_FROM: ${{ secrets.EMAIL_ADDRESS_FROM }}
11 changes: 6 additions & 5 deletions .github/workflows/test-against-nextjs-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:

env:
FORCE_COLOR: 3 # Diplay chalk colors
VERSION: ${{ inputs.version }}

jobs:
test_against_nextjs_release:
Expand All @@ -30,8 +31,8 @@ jobs:
cache: pnpm
- name: Install dependencies
run: pnpm install
- name: Install Next.js version ${{ inputs.version }}
run: pnpm add --filter e2e-next --filter nuqs next@${{ inputs.version }}
- name: Install Next.js version ${{ env.VERSION }}
run: pnpm add --filter e2e-next --filter nuqs "next@${{ env.VERSION }}"
- name: Run integration tests
run: pnpm run test --filter e2e-next
env:
Expand All @@ -45,13 +46,13 @@ jobs:
if: failure()
with:
path: packages/e2e-next/cypress/screenshots
name: ci-next-${{ inputs.version }}${{ matrix.base-path && '-basePath' || ''}}${{ matrix.react-compiler && '-react-compiler' || ''}}
name: ci-next-${{ env.VERSION }}${{ matrix.base-path && '-basePath' || ''}}${{ matrix.react-compiler && '-react-compiler' || ''}}
- uses: 47ng/actions-slack-notify@main
name: Notify on Slack
if: failure()
with:
status: ${{ job.status }}
jobName: next@${{ inputs.version }}${{ matrix.base-path && ' ⚾' || ''}}${{ matrix.react-compiler && ' ⚛️' || ''}}
jobName: next@${{ env.VERSION }}${{ matrix.base-path && ' ⚾' || ''}}${{ matrix.react-compiler && ' ⚛️' || ''}}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

Expand All @@ -73,6 +74,6 @@ jobs:
- uses: 47ng/actions-slack-notify@main
with:
status: ${{ job.status }}
jobName: ${{ inputs.version }}
jobName: '${{ env.VERSION }}'
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}