chore: Securing workflows #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise you end up in an infinite loop of the bot closing your PR.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Use the on.pull_request.paths to filter out relevant PRs, and trigger only on: - PRs by maintainers - PRs labeled with `deploy:preview`
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR removes risky GitHub Actions workflows to reduce the potential attack surface for token leaks and GHA misuse. The changes align with security best practices by eliminating workflows that could pose security risks while simplifying and improving the remaining automation.
- Completely removes snapshot release and ship-it workflows that required elevated permissions
- Simplifies pkg.pr.new workflow by removing approval-based triggers and using path-based filtering
- Enhances milestone automation with better error handling and support for updating linked issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/snapshot-release.yml |
Removes entire snapshot deployment workflow that used NPM tokens |
.github/workflows/ship-it.yml |
Removes workflow that required PAT tokens for branch management |
.github/workflows/pr-base-enforcement.yml |
Updates comment message to clarify PR reopening requirement |
.github/workflows/pkg.pr.new.yml |
Simplifies trigger logic by removing approval-based deployment and using path filtering |
.github/workflows/milestone-automation.yml |
Adds comprehensive linked issues milestone updating with error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
To avoid invalid expansions into arbitrary commands
64198d4 to
2632fe2
Compare
|
🎉 This PR is included in version 2.6.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective is to reduce the potential attack surface for token leaks & GHA misuse.
GITHUB_TOKENpermissions to be read-only by defaultmastertonext, unused)on.pull_request.paths, and remove approval-based trigger)Setting up proper OIDC trusted publishing for NPM will require
semantic-releaseto have official support.Resources:
Thanks @ciffelia for the tips!
Closes #1106.