autocomplete: Match insensitively to diacritics In @-mention results #588
Conversation
| doCheck('full full', eg.user(fullName: 'Full Full Name'), true); | ||
| doCheck('full full', eg.user(fullName: 'Full Name Full'), true); | ||
|
|
||
| // assert that name checking is diacritic insensitive |
There was a problem hiding this comment.
This could be enhanced with test groups but that will be against the pattern in this file, I imagine some little tweaks would be required.
I would prefer updating it but I try to follow the patterns I find in the codebase.
So.. what do you suggest?
|
Chat discussion about what dependency to pull in for this: https://chat.zulip.org/#narrow/stream/48-mobile/topic/deps.3A.20Add.20new.20package.20to.20handle.20diacritics/near/1770132 |
|
To update this thread: it looks like we've identified a dependency to pull in 🙂 https://chat.zulip.org/#narrow/stream/48-mobile/topic/deps.3A.20Add.20new.20package.20to.20handle.20diacritics/near/1770345 so I/we will be happy to see a revision that does that, and review this again when it's un-marked as a draft. |
Fixes #237
A new dependency was introduced: diacritic: ^0.1.5