Keycache test fixes#125
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR stabilizes key cache tests by fixing uninitialized buffer-size usage, unifying key ID initialization, and improving cleanup logic to avoid sporadic failures.
- Initialize
keyIdto a defined erased constant rather than arbitrary literals - Set
exportedKeySizebefore each export call to ensure correct buffer length - Refine eviction cleanup to handle both success and error paths and update error messages
Comments suppressed due to low confidence (1)
test/wh_test_crypto.c:972
- [nitpick] The message "after cache" may be confusing—consider "after caching key" or "after cache operation" for clarity on where it failed.
WH_ERROR_PRINT("Failed to export key after cache: %d\n",
billphipps
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes use of uninitialized variable as buffer size in/out argument, which caused sporadic test failures on hardware platforms