Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fabric: add page #14926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fabric: add page #14926

wants to merge 1 commit into from
+37 −0

Conversation

mjherich
Copy link

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): v1.4.107

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 21, 2024
@mjherich
Copy link
Author

@danielmiessler Let me know what you think about this tldr

gutjuri
gutjuri requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions.

pages/common/fabric.md
> Provides a modular framework for solving specific problems using a crowdsourced set of AI prompts.
> More information: <https://github.com/danielmiessler/fabric>.

- Run setup to configure fabric:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Run setup to configure fabric:
- Run the setup to configure fabric:

pages/common/fabric.md

`fabric --pattern {{pattern_name}} --output {{path/to/output_file}}`

- Run a pattern with specified variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Run a pattern with specified variables:
- Run a pattern with the specified variables:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjherich @CLAassistant @gutjuri