-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
at: update French and Chinese translation #14653
at: update French and Chinese translation #14653
Conversation
Feel free to update the |
Co-authored-by: Alexandre ZANNI <[email protected]>
Co-authored-by: Alexandre ZANNI <[email protected]>
Co-authored-by: Jin <[email protected]>
Co-authored-by: Jin <[email protected]>
BTW, @sebastiaanspeck @blueskyson, do we need to strictly keep tldr/contributing-guides/style-guide.zh.md Lines 244 to 249 in 1606ebd
I noticed some existing translations don’t fully follow this guideline. If we decide to enforce this strictly, I can review and adjust any inconsistent translations. |
Co-authored-by: Nicolas Kosinski <[email protected]>
If it is in the guideline, we should follow it. If you find translations who do not follow, feel free to open a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I "soft-approve": French version is OK for me but I can't approve the Chinese part. 😇
Co-authored-by: Jin <[email protected]>
Co-authored-by: Jin <[email protected]>
@Nico385412 @nicokosi @noraj could you please look at this PR? We are waiting for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now for the French part
Ref: #14220
common
,linux
,osx
,windows
,sunos
,android
, etc.