-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let: add page #14616
let: add page #14616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution.
pages/linux/let.md
Outdated
|
||
- Use conditional operator in an expression: | ||
|
||
`let "result = (x > 10) ? x : 0"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`let "result = (x > 10) ? x : 0"` | |
`let "{{result = (x > 10) ? x : 0}}"` | |
- Display help: | |
`let --help` |
pages/linux/let.md
Outdated
|
||
> Evaluate arithmetic expressions in shell. | ||
> Supports variables, operators, and conditional expressions. | ||
> More information: <https://phoenixnap.com/kb/bash-let>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should be using a more common documentation site. Although the manned.org/let does not have that much information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastiaanspeck, I noticed that manned.org doesn’t use a secure connection, and man7.org lacks documentation for the let
shell builtin command, which is kind of weird IMO.
How do you feel about using GNU's Bash reference instead? It provides concise documentation and links to the Shell Arithmetic section, which explains the syntax used as arguments for the let
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aggree with Sebas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've added manned.org link according to your suggestions. Please help me review it. 😄
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still an open comment. Please address that. After it has been addressed, it is GTG.
@sebastiaanspeck I cannot apply my own suggestion because it is on pending, how can I apply it? Thanks. |
By finishing your review :) |
|
pages/linux/let.md
Outdated
|
||
> Evaluate arithmetic expressions in shell. | ||
> Supports variables, operators, and conditional expressions. | ||
> More information: <https://phoenixnap.com/kb/bash-let>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastiaanspeck, I noticed that manned.org doesn’t use a secure connection, and man7.org lacks documentation for the let
shell builtin command, which is kind of weird IMO.
How do you feel about using GNU's Bash reference instead? It provides concise documentation and links to the Shell Arithmetic section, which explains the syntax used as arguments for the let
command.
pages/linux/let.md
Outdated
|
||
> Evaluate arithmetic expressions in shell. | ||
> Supports variables, operators, and conditional expressions. | ||
> More information: <https://phoenixnap.com/kb/bash-let>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've added manned.org link according to your suggestions. Please help me review it. 😄
Thanks!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, LGTM! 🎉
Co-authored-by: Wiktor Perskawiec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added @spageektti's suggestion to add the let --help
example. Going to merge this now. Thanks for your contribution @jackiesogi!
common
,linux
,osx
,windows
,sunos
,android
, etc.