Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let: add page #14616

Merged
merged 6 commits into from
Nov 22, 2024
Merged

let: add page #14616

merged 6 commits into from
Nov 22, 2024

Conversation

jackiesogi
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 4, 2024
pages/linux/let.md Outdated Show resolved Hide resolved
pages/linux/let.md Outdated Show resolved Hide resolved
pages/linux/let.md Outdated Show resolved Hide resolved
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the suggestions

Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution.


- Use conditional operator in an expression:

`let "result = (x > 10) ? x : 0"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`let "result = (x > 10) ? x : 0"`
`let "{{result = (x > 10) ? x : 0}}"`
- Display help:
`let --help`


> Evaluate arithmetic expressions in shell.
> Supports variables, operators, and conditional expressions.
> More information: <https://phoenixnap.com/kb/bash-let>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should be using a more common documentation site. Although the manned.org/let does not have that much information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastiaanspeck, I noticed that manned.org doesn’t use a secure connection, and man7.org lacks documentation for the let shell builtin command, which is kind of weird IMO.

How do you feel about using GNU's Bash reference instead? It provides concise documentation and links to the Shell Arithmetic section, which explains the syntax used as arguments for the let command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aggree with Sebas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've added manned.org link according to your suggestions. Please help me review it. 😄

jackiesogi and others added 3 commits November 5, 2024 15:44
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an open comment. Please address that. After it has been addressed, it is GTG.

@jackiesogi
Copy link
Contributor Author

There is still an open comment. Please address that. After it has been addressed, it is GTG.

Screenshot from 2024-11-13 03-29-12

@sebastiaanspeck I cannot apply my own suggestion because it is on pending, how can I apply it? Thanks.

@sebastiaanspeck
Copy link
Member

There is still an open comment. Please address that. After it has been addressed, it is GTG.

Screenshot from 2024-11-13 03-29-12

@sebastiaanspeck I cannot apply my own suggestion because it is on pending, how can I apply it? Thanks.

By finishing your review :)

@spageektti
Copy link
Member

spageektti commented Nov 12, 2024

There is still an open comment. Please address that. After it has been addressed, it is GTG.

Screenshot from 2024-11-13 03-29-12

@sebastiaanspeck I cannot apply my own suggestion because it is on pending, how can I apply it? Thanks.

Zrzut ekranu_20241112_214201


> Evaluate arithmetic expressions in shell.
> Supports variables, operators, and conditional expressions.
> More information: <https://phoenixnap.com/kb/bash-let>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastiaanspeck, I noticed that manned.org doesn’t use a secure connection, and man7.org lacks documentation for the let shell builtin command, which is kind of weird IMO.

How do you feel about using GNU's Bash reference instead? It provides concise documentation and links to the Shell Arithmetic section, which explains the syntax used as arguments for the let command.

pages/linux/let.md Outdated Show resolved Hide resolved

> Evaluate arithmetic expressions in shell.
> Supports variables, operators, and conditional expressions.
> More information: <https://phoenixnap.com/kb/bash-let>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've added manned.org link according to your suggestions. Please help me review it. 😄

@jackiesogi
Copy link
Contributor Author

There is still an open comment. Please address that. After it has been addressed, it is GTG.

Screenshot from 2024-11-13 03-29-12
@sebastiaanspeck I cannot apply my own suggestion because it is on pending, how can I apply it? Thanks.

Zrzut ekranu_20241112_214201

Thanks!!!

Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, LGTM! 🎉

Co-authored-by: Wiktor Perskawiec <[email protected]>
Copy link
Collaborator

@nelsonfigueroa nelsonfigueroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added @spageektti's suggestion to add the let --help example. Going to merge this now. Thanks for your contribution @jackiesogi!

@nelsonfigueroa nelsonfigueroa merged commit 4df55c6 into tldr-pages:main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants