Skip to content

improve chatInviteLinkInfo docs - #1124

Closed
mymike00 wants to merge 1 commit into
tdlib:masterfrom
mymike00:patch-1
Closed

improve chatInviteLinkInfo docs#1124
mymike00 wants to merge 1 commit into
tdlib:masterfrom
mymike00:patch-1

Conversation

@mymike00

@mymike00 mymike00 commented Jul 5, 2020

Copy link
Copy Markdown

The chat_id field in chatInviteLinkInfo claims to be 0 if the user isn't a member of the chat.
In fact, if the user isn't a member of the chat but the chat is public the chat_id is not 0

If you find a better phrasing than mine, go ahead and edit it, I'm not that good with English...

@levlam

levlam commented Jul 5, 2020

Copy link
Copy Markdown
Contributor

Thanks! You are right.

In fact, in the non-pushed to Github version the field description has already been fixed to "Chat identifier of the invite link; 0 if the user have no access to the chat before joining".

@mymike00

mymike00 commented Jul 5, 2020

Copy link
Copy Markdown
Author

Ah, great to hear you already fixed it 👍

btw, why don't you push your changes right after you do them?

@levlam

levlam commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

@mymike00 TDLib source code is pushed once the corresponding version is suitable for general use. Current development version uses unstable server API, which breaks on a daily basis. API changes also often causes backward incompatible changes in TDLib during the development.

Currently, it is not possible to move the whole development to Github and even it is moved the corresponding version would be suitable for development only.

@mymike00

mymike00 commented Jul 6, 2020

Copy link
Copy Markdown
Author

What about a development branch where you push the unstable code and then merge it into master when it gets more stable?

@levlam

levlam commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

@mymike00 As I said, this is currently not possible, because source code is extracted from the private repository using automated tool. Private and public git repositories has no common ancestor.

@mymike00

mymike00 commented Jul 6, 2020

Copy link
Copy Markdown
Author

Ok, I understand. thank you for your help

@mymike00 mymike00 closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants