fix: Add cycle detection and performance optimization to schema reference resolution #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence resolution - Add visited_refs parameter to detect and break circular references - Add skip_components parameter to avoid unnecessary deep resolution - Add resolve_schema_for_display function for JIT schema resolution with caching - Prevents infinite recursion on schemas with circular references - Improves performance by avoiding resolution of entire components tree Fixes issue where resolve_schema_references could cause infinite recursion on OpenAPI schemas containing circular references between components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes issue where
resolve_schema_referencescould cause infinite recursion on OpenAPI schemas containing circular references between components.visited_refsparameter to detect and break circular referencesskip_componentsparameter to avoid unnecessary deep resolutionresolve_schema_for_displayfunction for JIT schema resolution with cachingIssue ticket number and link (if applicable)
Screenshots of the feature / bugfix
Checklist before requesting a review