fix(tool): replace wrong tool references LS and Agent
#2466
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize tool references to use capitalized names consistently. Change 'LS tool' to 'List tool' and 'list' to 'List' to match the documentation convention used by other tools like Read, Grep, Glob, and Task. Fixes incorrect references that were confusing the actual tool name.
Fix incorrect references to non-existent 'Agent tool' in glob, grep, and task tool descriptions. These tools were incorrectly instructing users to use the 'Agent tool' instead of the actual 'Task tool' for launching agents. This bug could mislead users into thinking there was a separate 'Agent tool' when they should be using the Task tool with subagent_type parameter. Fixes documentation inconsistencies that were causing confusion about the proper tool usage for launching agents.
|
As an aside: I noticed that tool call reliability improves if we lowercase the tool names (e.g. |
|
going to ask Dax to review just incase there was some intentionality here but to me it looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
LSandAgentdon't exist. The correct tool names areListandTask. This fixes some invalid tool calls agents might make.