-
Notifications
You must be signed in to change notification settings - Fork 253
CLDSRV-717: Test lifecycle Transition condition #5893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-717: Test lifecycle Transition condition #5893
Conversation
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.0 #5893 +/- ##
===================================================
- Coverage 83.12% 83.11% -0.01%
===================================================
Files 188 188
Lines 12046 12046
===================================================
- Hits 10013 10012 -1
- Misses 2033 2034 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
f05d271 to
2de3555
Compare
tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js
Outdated
Show resolved
Hide resolved
tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js
Outdated
Show resolved
Hide resolved
2de3555 to
655fca4
Compare
For S3C Integration that don't support Transition
655fca4 to
032a9c4
Compare
| const isTransitionSupported = config.supportedLifecycleRules.includes('Transition'); | ||
|
|
||
| (isTransitionSupported ? describe.skip : describe)('with Transitions NOT supported', () => { | ||
| it('should return NotImplemented if Transitions rule', done => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| it('should return NotImplemented if Transitions rule', done => { | |
| it('should return NotImplemented if rules does not include Transitions', done => { |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the reverse, if rules include Transitions
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-717. Goodbye bourgoismickael. |
For S3C Integration that don't support Transition