-
Notifications
You must be signed in to change notification settings - Fork 248
Pass instanceId to mongodb metadata backend #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development/8.8
Are you sure you want to change the base?
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
@@ Coverage Diff @@
## improvement/CLDSRV-715 #5826 +/- ##
==========================================================
+ Coverage 65.08% 65.10% +0.02%
==========================================================
Files 188 188
Lines 11948 11956 +8
==========================================================
+ Hits 7776 7784 +8
Misses 4172 4172
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as discussed, let's add the base62 as the default during tests as well, so we are actually testing what is used in production
187bb49
to
526ed7b
Compare
526ed7b
to
892f4cd
Compare
06d051c
to
85ab804
Compare
Note for reviewers, i updated this PR following the changes in the TAD. |
@Kerkesni do we want to target 8.8? Some clients might not be ready to upgrade to the latest product version right away |
85ab804
to
6db3320
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
@williamlardier yes forgot about that part, thanks |
735f683
to
3e340d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise, but let's wait for the finalized Arsenal part
d1c6b67
to
a7fd024
Compare
instanceId will be used when generating versionIds. This will ensure uniqueness of the versionID across all Cloudserver pods in the cluster. The instanceId is a combination of the short hash contained in the name of the pods, which is unique across all pods within the same deployment, and a prefix for differenciating the different types of deployments (internal vs external). see. https://scality.atlassian.net/wiki/spaces/OS/pages/3225583692/VersionID+Collisions+in+Zenko Issue: CLDSRV-665
Cloudserver in Zenko always uses base62 encoding, so we enforce it in the mongo tests. Issue: CLDSRV-665
a7fd024
to
21464a5
Compare
instanceId
will be used when generating versionIds.This will ensure uniqueness of the versionID across
all Cloudserver pods in the cluster.
The
instanceId
is a combination of the short hashcontained in the name of the pods, which is unique
across all pods within the same deployment, and a
prefix for differenciating the different types of
deployments (internal vs external).
see. https://scality.atlassian.net/wiki/spaces/OS/pages/3225583692/VersionID+Collisions+in+Zenko
Related PR: scality/Arsenal#2445
Issue: CLDSRV-665