-
Notifications
You must be signed in to change notification settings - Fork 7k
[data][train] Package iter_batches as a class
#55410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
srinathk10
approved these changes
Aug 8, 2025
Contributor
srinathk10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
Contributor
|
Nice refactor! |
Signed-off-by: Justin Yu <[email protected]>
sampan-s-nayak
pushed a commit
that referenced
this pull request
Aug 12, 2025
Lightweight refactor of `iter_batches` into a class. This will allow individual pipeline stages to store state on the `BatchIterator` instance and pass context to other stages. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: sampan <[email protected]>
dioptre
pushed a commit
to sourcetable/ray
that referenced
this pull request
Aug 20, 2025
Lightweight refactor of `iter_batches` into a class. This will allow individual pipeline stages to store state on the `BatchIterator` instance and pass context to other stages. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Andrew Grosser <[email protected]>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
Lightweight refactor of `iter_batches` into a class. This will allow individual pipeline stages to store state on the `BatchIterator` instance and pass context to other stages. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: jugalshah291 <[email protected]>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
Lightweight refactor of `iter_batches` into a class. This will allow individual pipeline stages to store state on the `BatchIterator` instance and pass context to other stages. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
snorkelopstesting2-coder
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_55410_5330db26-b6d2-42c8-aadf-3fc8107b4eb8
that referenced
this pull request
Oct 22, 2025
Original PR #55410 by justinvyu Original: ray-project/ray#55410
snorkelopstesting3-bot
added a commit
to snorkel-marlin-repos/ray-project_ray_pr_55410_5330db26-b6d2-42c8-aadf-3fc8107b4eb8
that referenced
this pull request
Oct 22, 2025
Merged from original PR #55410 Original: ray-project/ray#55410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lightweight refactor of
iter_batchesinto a class. This will allow individual pipeline stages to store state on theBatchIteratorinstance and pass context to other stages.