-
Notifications
You must be signed in to change notification settings - Fork 152
fix: styled modal alignment #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r right/botto
🦋 Changeset detectedLatest commit: 2efc5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hey @lolzivkovic thanks for the submission! I tried it out locally and can't see any difference with your added changes. Could you share a screenshot? |
Hi @maiieul, Of course, here are the changes and how they are reflected when using position="right" and for example width of 300px for modal Here is what it looks like in Firefox(139.0.1): Here is what it looks like in Chromium(137.0.7151.68): Also ml-0, mr-0, mb-0 and mt-0 seem redundant as well after the change. |
Okay, I still don't see the difference on local, but I guess it doesn't hurt so I'll merge. Thanks for the PR 👍 |
commit: |
This PR fixes alignment issues with Modals when position is set to bottom or right
What is it?
Why is it needed?
When trying to use Modal a Sheet it does not align properly when position set is either bottom or right
Checklist:
pnpm change
and documented my changes