gh-127182: Fix io.StringIO.__setstate__
crash when None
is the first value
#127219
+33
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
None
value in__setstate__
, it cannot be recieved normally, because__getstate__
never returnsNone
, but we should not let a simple direct call to crash, when the fix is rather simple__init__
method:cpython/Modules/_io/stringio.c
Line 898 in f7bb658
None
is an allowed input value, seecpython/Modules/_io/stringio.c
Line 693 in f7bb658
None
in__setstate__
NULL
cannot be passed to__setstate__
, because it requires atuple
inputStringIO.__setstate__
#127182