OIDC: use info in id_token if not in response #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
reviewed
Sep 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 78.04% 78.05%
=======================================
Files 354 354
Lines 10915 10918 +3
Branches 481 483 +2
=======================================
+ Hits 8519 8522 +3
Misses 2224 2224
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nijel
reviewed
Sep 11, 2025
| @@ -337,12 +337,19 @@ def user_data(self, access_token, *args, **kwargs): | |||
|
|
|||
| def get_user_details(self, response): | |||
| username_key = self.setting("USERNAME_KEY", self.USERNAME_KEY) | |||
| # populate response with id_token if needed | |||
There was a problem hiding this comment.
Suggested change
| # populate response with id_token if needed |
Comment on lines
347
to
353
| return { | ||
| "username": response.get(username_key), | ||
| "email": response.get("email"), | ||
| "fullname": response.get("name"), | ||
| "first_name": response.get("given_name"), | ||
| "last_name": response.get("family_name"), | ||
| "username": user_details.get(username_key), | ||
| "email": user_details.get("email"), | ||
| "fullname": user_details.get("name"), | ||
| "first_name": user_details.get("given_name"), | ||
| "last_name": user_details.get("family_name"), | ||
| } |
There was a problem hiding this comment.
Wouldn't just return user_details work the same? It has all the keys now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developpers,
When using the OpenIdConnectAuth class with a ADFS IdP I got an issue because the email and
USERNAME_KEYwas not part of the response but part of the id_token.The changes I made propose to use the info from the id_token if the key is not present in the response.
I don't know if this makes sense or if this should be a new Class.
I don't know how to make a test for this.