feat: send user agent by default #1258
Merged
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now needed by mediawiki.py (Wikimedia policy has required it for some 15 years [1], and more recently has enforced it more strictly, see T400119 [2]), but discussion in python-social-auth#1241 concluded that it should really be enabled by default for all sites. If it turns out to break anything, that particular backend can override it to False again. [1]: https://lists.wikimedia.org/hyperkitty/list/[email protected]/message/R4RU7XTBM5J3BTS6GGQW77NYS2E4WGLI/ [2]: https://phabricator.wikimedia.org/T400119
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
- Coverage 78.04% 78.04% -0.01%
==========================================
Files 354 354
Lines 10915 10911 -4
Branches 481 481
==========================================
- Hits 8519 8515 -4
+ Misses 2224 2223 -1
- Partials 172 173 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now needed by mediawiki.py (Wikimedia policy has required it for some 15 years, and more recently has enforced it more strictly, see T400119), but discussion in #1241 concluded that it should really be enabled by default for all sites. If it turns out to break anything, that particular backend can override it to False again.