Skip to content

Remove envoy stats hostport from example manifests#7476

Merged
tsaarni merged 1 commit into
projectcontour:mainfrom
Nordix:envoy-stats-example
Mar 21, 2026
Merged

Remove envoy stats hostport from example manifests#7476
tsaarni merged 1 commit into
projectcontour:mainfrom
Nordix:envoy-stats-example

Conversation

@tsaarni

@tsaarni tsaarni commented Mar 20, 2026

Copy link
Copy Markdown
Member

This PR removes the Envoy stats (metrics) hostPort 8002 from the example deployment manifests in examples. Exposing metrics in host networking is not recommended for general deployments, so the examples should not include it.

Since the e2e test suite uses these manifests but still requires port access for stats, this PR also updates the suite to expose the port programmatically.

Fixes #7475

@tsaarni tsaarni requested a review from a team as a code owner March 20, 2026 19:04
@tsaarni tsaarni requested review from sunjayBhatia and removed request for a team March 20, 2026 19:04
@tsaarni tsaarni added the release-note/small A small change that needs one line of explanation in the release notes. label Mar 20, 2026
@sunjayBhatia sunjayBhatia requested review from a team, clayton-gonsalves and rajatvig and removed request for a team March 20, 2026 19:04
@tsaarni tsaarni force-pushed the envoy-stats-example branch 2 times, most recently from 57fd002 to 2bc5759 Compare March 20, 2026 19:10
@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (23ba0a6) to head (bd29c0c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7476   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         130      130           
  Lines       15722    15722           
=======================================
  Hits        12868    12868           
  Misses       2571     2571           
  Partials      283      283           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
@tsaarni tsaarni force-pushed the envoy-stats-example branch from 2bc5759 to bd29c0c Compare March 20, 2026 19:25
@tsaarni tsaarni merged commit f7cd812 into projectcontour:main Mar 21, 2026
27 checks passed
tsaarni added a commit to Nordix/contour that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni added a commit to Nordix/contour that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni added a commit to Nordix/contour that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni added a commit that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni added a commit that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni added a commit that referenced this pull request Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/small A small change that needs one line of explanation in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove envoy stats hostPort in example manifest

1 participant