Remove envoy stats hostport from example manifests#7476
Merged
Conversation
57fd002 to
2bc5759
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7476 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 130 130
Lines 15722 15722
=======================================
Hits 12868 12868
Misses 2571 2571
Partials 283 283 🚀 New features to boost your workflow:
|
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
2bc5759 to
bd29c0c
Compare
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Mar 23, 2026
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
This was referenced Mar 23, 2026
tsaarni
added a commit
that referenced
this pull request
Mar 23, 2026
tsaarni
added a commit
that referenced
this pull request
Mar 23, 2026
tsaarni
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the Envoy stats (metrics) hostPort 8002 from the example deployment manifests in examples. Exposing metrics in host networking is not recommended for general deployments, so the examples should not include it.
Since the e2e test suite uses these manifests but still requires port access for stats, this PR also updates the suite to expose the port programmatically.
Fixes #7475