Post-process HTTPProxy CRD schema to remove error as a required field#7408
Merged
Merged
Conversation
bbe71cc to
0b5f8f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7408 +/- ##
=======================================
Coverage 81.85% 81.85%
=======================================
Files 130 130
Lines 15766 15766
=======================================
Hits 12906 12906
Misses 2576 2576
Partials 284 284 🚀 New features to boost your workflow:
|
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
0b5f8f0 to
986a537
Compare
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Feb 8, 2026
…projectcontour#7408) Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Feb 8, 2026
…projectcontour#7408) Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Feb 8, 2026
…projectcontour#7408) Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
added a commit
to Nordix/contour
that referenced
this pull request
Feb 8, 2026
…projectcontour#7408) Signed-off-by: Tero Saarni <tero.saarni@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a post-processing step to
make generateto preventstatus.loadBalancer.ingress[].ports[].errorfrom being incorrectly marked asrequiredin theHTTPProxyCRD schema, which caused load balancer status update failures.The issue happens because the
HTTPProxyembeds the Kubernetescore_v1.LoadBalancerStatus. This type containsPortStatusstruct with some conflicting markers, and controller-tools v0.16.x changed how it handles conflicting+optionaland+kubebuilder:validation:Required marker. Rewriting the status struct to remove its dependency on the external package would be best solution, but it would break Go API compatibility forHTTPProxy.The modification uses
kubectl patchwith the exact path to the data structure and includes test for recognizing if the field is still there before processing. This approach should be robust and not affect wrong fields.Fixes #7391