refactor: Lazily load docsearch only on intent to interact #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a0dfb0 to
278bfb7
Compare
rschristian
commented
Aug 16, 2025
Comment on lines
-1
to
+3
| @import '@docsearch/css'; | ||
|
|
||
| .DocSearch-Button { | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
The extra CSS in this file is to compensate for @docsearch/css no longer being here to build upon. Should look identical
JoviDeCroock
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of lazily loading Docsearch (which offers only a momentary delay in downloading the chunk as it's used in the header), let's lazily load it only upon intent to interact, i.e., upon focus, mouse over, touch start, etc. If they user interacts with the docsearch button prior to mount, we'll show a loading bar & trigger a click imperatively once it's loaded, getting around any "jank" issues where the user will need to submit another click/enter key (if tabbing), etc.
Cuts the initial JS load by about 47% or 28kb. Couple kbs less of CSS too, as that'll lazy load now as well.