refactor: Don't redirect json/content 404's to 404 page #1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify, via our config here, is set up to redirect all 404'ing requests to
/404/index.html
, which isn't unreasonable for most pages but our "guess and check" method of fetching translated content makes this a bit wasteful. In the event of a missing translation file, all we do is read the status code & discard the response body, which is the prerendered 404 page (~3kb w/ gzip):preact-www/src/lib/content.js
Lines 16 to 18 in 4cf9283
We could (and perhaps should) build a content manifest to skip some of these needless fetches, in the meantime, we can return a smaller asset at the very least. Reduces data egress & is likely faster for Netlify to respond with.