Skip to content

Conversation

schrer
Copy link
Contributor

@schrer schrer commented Apr 13, 2022

Description

Changed the outdated link in the Goals paragraph inside the README to point to #react-redux-typescript-ecosystem

Related issues:

Checklist

  • I have read CONTRIBUTING.md
  • I have edited README_SOURCE.md (NOT README.md)
  • I have run CI script locally npm run ci-check to generate an updated README.md
  • I have linked all related issues above
  • I have rebased my branch
Siteproxy

Siteproxy

搜索引擎


常用网站


新闻网站


海外论坛


@schrer
Copy link
Contributor Author

schrer commented Apr 13, 2022

I am not familiar with Semaphore CI, but I can't seem to find any details on why exactly the build failed.

All I can say is, that locally running npm run ci-check worked as intended, as long as I was using a node version below 13 on my Fedora 35 laptop (I used Node 12 LTS in the end). Versions after 13 did not seem to be able to run the script generate-readme.js because of an issue, with fs.writeFileSync. Could that be the issue here? Not sure how the Semaphore build is defined.

Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let me check what's up with the build

@piotrwitek
Copy link
Owner

Hey @schrer, there was a problem with CI because of the newer node version as you said thanks for that :)
I have updated the script to run on newer node runtimes so should be working now, could you please rebase?

@schrer
Copy link
Contributor Author

schrer commented Apr 14, 2022

Done.
Thanks for checking the build, and happy to help out :)

@piotrwitek piotrwitek merged commit d5aee54 into piotrwitek:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to missing anchor in the guide
2 participants