Replace deprecated modules in playground #176
Merged
+4,117
−7,812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'react-router-redux' with 'connected-react-router'
The old verion of have to many vulnerability complains Also update two peer dependencies: react-redux, axios Adjust 'error-message' component according to new 'react-scripts' warning that appeas after `npm start` cmd
piotrwitek
requested changes
Jul 10, 2019
playground/package.json
Outdated
| "cuid": "2.1.6", | ||
| "prop-types": "15.7.2", | ||
| "react": "16.8.6", | ||
| "react-dom": "16.8.6", | ||
| "react-redux": "7.0.2", | ||
| "react-redux": "7.1.0", | ||
| "react-redux-typescript-scripts": "1.5.0", | ||
| "react-router-dom": "4.3.1", | ||
| "react-router-redux": "5.0.0-alpha.8", |
There was a problem hiding this comment.
react-router-redux shoould be removed from deps
There was a problem hiding this comment.
sry, somehow I missed it
piotrwitek
approved these changes
Jul 10, 2019
|
@incerta Thanks for your contribution. It looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175 Replace 'react-router-redux' with 'connected-react-router'
Also I noticed a lot of vulnerability warnings related to
react-scripts, so I had update it and alsoreact-redux,axios. For now we don't havevulnerabilitycomplains afternpm i.@babel/polyfillis deprecated for the newreact-scriptsenvironment, so I remove this dependency and adjustsrc/index.tsx