fix(ui): unreachable custom views when admin route set to '/' #12812
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
requested changes
Jun 18, 2025
There was a problem hiding this comment.
Thanks for taking this on @rubyjasmin! Seems like we might not need to replace the admin route to begin with, though, as it's already sanitized before being sent to getCustomViewByRoute. I'm going to make a few small changes to reflect this.
Then we also need a test for this to prevent future regression. I'll take care of this too.
jacobsfletch
approved these changes
Jun 26, 2025
|
🚀 This is included in version v3.44.0 |
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12811
Custom Views become unreachable when admin route is set to "/" because the forward slash of the current route gets removed before routing to custom view