feat(ui): supports collection scoped folders #12797
Open
+2,119
−760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the new scope
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
requested changes
Jul 8, 2025
There was a problem hiding this comment.
I tested this manually and it looked great!
The test coverage gives me confidence.
I found a few nit-picks in the code.
The only thing other thing not 100% sure on is the name of the new field, "Folder Type". If a user overrides the label on their folders feature, this makes little sense.
| breadcrumbsPromise, | ||
| documentAndSubfolderPromise, | ||
| ]) | ||
|
|
||
| return { | ||
| breadcrumbs, | ||
| documents: documentsAndSubfolders.documents, | ||
| subfolders: documentsAndSubfolders.subfolders, | ||
| documents: sortDocs({ docs: result.documents, sort }), |
There was a problem hiding this comment.
This is the kind of thing that I thought the DB adapters would help us with because we are using the join field.
There was a problem hiding this comment.
I don't think this is possible, the folders collection and all related document types would need to have a name field for sort and pagination to work together on the join field. We cannot guarantee that, which reminds me why I think we should query docs separately in the future. This would allow for proper sorting and pagination since each collection would be in charge of their own querying — topic for a later date.
There was a problem hiding this comment.
If we queried them separately then we would also be able to have more sensible tables that can show more than name/createdAt/updatedAt.
I agree with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this RFC, this PR supports collection-scoped folders. You can scope folders to multiple collection types or just one.
This unlocks the possibility to have folders on a per collection instead of always being shared on every collection. You can combine this feature with the
browseByFolder: falseto completely isolate a collection from other collections.Things left to do:
Create a custom react component for the selecting of collectionSlugs to filter out available options based on the current folders parametersfolders-per-collection.mp4