Skip to content

BUG: Add PyArrow datelike type support for map() #61644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KevsterAmp wants to merge 13 commits into from
Closed

BUG: Add PyArrow datelike type support for map() #61644

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
78b92c4
call self.to_numpy() when self.dtype.pyarrow_dtype is datelike
KevsterAmp Jun 13, 2025
ffb2a6f
refactor to combine in one if block
KevsterAmp Jun 13, 2025
bd1b70c
fix stringdtype issue
KevsterAmp Jun 26, 2025
8efb78d
Merge remote-tracking branch 'upstream/main' into pyarrow-timestamp-map
KevsterAmp Jun 26, 2025
a741e4b
Merge remote-tracking branch 'upstream' into pyarrow-timestamp-map
KevsterAmp Jul 9, 2025
38f375a
use self.dtype.kind to filter all datetimelike
KevsterAmp Jul 9, 2025
ecf2d31
fix tests
KevsterAmp Jul 9, 2025
ab84b92
fix self.dtype.kind filter
KevsterAmp Jul 9, 2025
d3d1c17
fix precommit
KevsterAmp Jul 9, 2025
a2e1c34
remove dtype=object to fix tests
KevsterAmp Jul 9, 2025
76e14a3
Merge remote-tracking branch 'upstream/main' into pyarrow-timestamp-map
KevsterAmp Jul 23, 2025
c9b16de
add tests specific to the issue
KevsterAmp Aug 6, 2025
233d1b0
Merge remote-tracking branch 'upstream/main' into pyarrow-timestamp-map
KevsterAmp Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor to combine in one if block
  • Loading branch information
@KevsterAmp
KevsterAmp committed Jun 13, 2025
commit ffb2a6f358fcb94d1922367756502947e4dab685
8 changes: 4 additions & 4 deletions pandas/core/arrays/arrow/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,10 +1478,10 @@ def to_numpy(
return result

def map(self, mapper, na_action: Literal["ignore"] | None = None):
if is_numeric_dtype(self.dtype):
return map_array(self.to_numpy(), mapper, na_action=na_action)
elif pa.types.is_date(self.dtype.pyarrow_dtype) or pa.types.is_timestamp(
self.dtype.pyarrow_dtype
if (
is_numeric_dtype(self.dtype)
or pa.types.is_date(self.dtype.pyarrow_dtype)
or pa.types.is_timestamp(self.dtype.pyarrow_dtype)
):
Copy link
Member

@jbrockmendel jbrockmendel Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why the super().map method isn't working correctly? If fixing things there is viable, that would be a better outcome

return map_array(self.to_numpy(), mapper, na_action=na_action)
else:
Expand Down
Loading