Skip to content

BUG: Require sample weights to sum to less than 1 when replace = True #61582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhshadrach merged 6 commits into from
Jul 11, 2025
Merged

BUG: Require sample weights to sum to less than 1 when replace = True #61582

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46e70ef
implement the exception
microslaw Jun 12, 2025
d18c74b
remove impossible test scenario
microslaw Jun 12, 2025
f562384
add new tests
microslaw Jun 12, 2025
e4e2cbf
update documentation
microslaw Jun 12, 2025
c4241fb
tmp
microslaw Jun 29, 2025
7b9aac4
doc: minior adjustments
microslaw Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove impossible test scenario
  • Loading branch information
@microslaw
microslaw committed Jul 8, 2025
commit d18c74b7dfd9a2a121fd9f50c7bc7786abda9cbb
3 changes: 0 additions & 3 deletions pandas/tests/frame/methods/test_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ def test_sample_invalid_weight_lengths(self, obj):
with pytest.raises(ValueError, match=msg):
obj.sample(n=3, weights=[0.5] * 11)

with pytest.raises(ValueError, match="Fewer non-zero entries in p than size"):
obj.sample(n=4, weights=Series([0, 0, 0.2]))

def test_sample_negative_weights(self, obj):
# Check won't accept negative weights
bad_weights = [-0.1] * 10
Expand Down