Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: add some missing npm_ env vars #14786

Merged
merged 16 commits into from
Nov 22, 2024
Merged

pm: add some missing npm_ env vars #14786

merged 16 commits into from
Nov 22, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Oct 24, 2024

Closes #73
Closes #2793
Closes #13803

@robobun
Copy link

robobun commented Oct 24, 2024

@dylan-conway, your commit 8c22ecf has 16 failures in #6711:

  • test/js/third_party/pino/pino.test.js - segmentation fault at address 0x180f8884440 on 🪟 2019 x64-baseline
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 2019 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/cli/install/bun-run.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 aarch64
  • test/cli/install/bun-create.test.ts - timeout on 🐧 22.04 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 11 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 20.04 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 22.04 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🍎 14 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 12 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🍎 13 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 20.04 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 12 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 22.04 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 11 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 11 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 3.20 aarch64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 22.04 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 12 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 20.04 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🪟 2019 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🪟 2019 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 3.20 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🐧 3.20 x64-baseline
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🍎 13 x64
  • test/js/third_party/prisma/prisma.test.ts - code 1 on 🍎 14 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 11 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 12 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 11 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 11 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🪟 2019 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 13 x64
  • test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 14 x64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 14 x64
  • @nektro nektro marked this pull request as ready for review October 24, 2024 10:08
    Copy link
    Member

    @dylan-conway dylan-conway left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A test should be added to bun-workspace.test.ts for multiple package.json with config fields

    @hadarziv-army
    Copy link

    It looks like it should close my issue too #13803

    Copy link
    Member

    @dylan-conway dylan-conway left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Could you also add a test for npm_command publish in bun-install-registry.test.ts

    @dylan-conway dylan-conway merged commit 82cb82d into main Nov 22, 2024
    4 of 6 checks passed
    @dylan-conway dylan-conway deleted the nektro-patch-63803 branch November 22, 2024 23:13
    @whyman
    Copy link

    whyman commented Nov 23, 2024

    This is awesome!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    5 participants