Add ECS and Logs attributes based on Metadata v4 endpoint#875
Conversation
|
@mmanciop Please sign the CLA. |
c8056d7 to
4f30336
Compare
e7430ae to
49ac4d3
Compare
|
I am actually not 100% sure yet of the patchset wrt the implementation of the IResourceDetector interface. I am going to try it out on a test app. Update: It seems to me we need to get rid of the local |
3c5403f to
4d189d8
Compare
|
@srprash, @lupengamzn could you please check? |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I agree that this must go out as a major version bump.
Yup. We can do that to be inline with the rest of the packages in the repo. I wish we can do the same for the OpenTelemetry.Contrib.Instrumentation.AWS package as well while bumping its major version.
I have no issues in dropping XRay and renaming the package to be |
|
@mmanciop, finally we have an approval from the package owner. |
|
@Kielek @srprash I solved the conflicts and did some cleanup, but I am assuming that version bumping, extension renaming and the rest mentioned in #875 (comment) will be performed by the package owners, right? |
|
For sure as a separate PR. |
… endpoint Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Changes
Implement
aws.ecsandaws.logresource attributes with data from the ECS Metadata endpoint v4.CHANGELOG.mdupdated for non-trivial changes