#201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource#205
Merged
srprash merged 2 commits intoFeb 14, 2022
Conversation
…ntainerID independently before adding it to the resource - Validates ClusterName/ContainerID independently before adding it to the resource - Includes bug fix - IsEKSProcess should return non-null auth value to confirm if its running in EKS environment. - Handled exceptions separately with more error information - Added Unit Tests
|
|
srprash
approved these changes
Feb 14, 2022
srprash
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making this change. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#201 AWSEKSResourceDetector - Validate ClusterName/ContainerID independently before adding it to the resource