Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
httpsto leverage service workers and push API locally.Notes:
https://onlook.internaltolocalhost:3000./etc/hoststo be edited to add127.0.0.1 onlook.internallocalhost:3000can still be usedonlook.internalinstead oflocalhostlocalhostis not valid).internalis specifically reserved for internal usageUsing docker to host
nginxmight feel overkill, but the container image is relatively small because it uses alpine and it simplifies the setup of the environment.Related Issues
Type of Change
Testing
bun backend:start– will ask you for password to add certificate to key chainbun devsudo vim /etc/hostsand add127.0.0.1 onlook.internalopen https://onlook.internalScreenshots (if applicable)
Additional Notes
Important
Adds local HTTPS support using Nginx in Docker, with SSL certificate generation and configuration for
onlook.internal.server.confto reverse proxyhttps://onlook.internaltolocalhost:3000.docker-compose.yamlto run Nginx in a Docker container.package.jsonto run Nginx setup withbackend:startscript.genkeys.shto generate SSL certificates and add them to the Mac keychain.openssl.cnffor certificate configuration..gitignorefor SSL files.config.tomlto includehttps://onlook.internalinadditional_redirect_urls.This description was created by
for 65486f3. You can customize this summary. It will automatically update as commits are pushed.