-
Notifications
You must be signed in to change notification settings - Fork 96
fix: Include tests without .nuxt.
extension
#1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e for the default environment
commit: |
3eedc39
to
41f0759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! might it be possible to add a simple fixture to the examples/
directory so we avoid this regression happening again?
a9addc8
to
0ef0a76
Compare
01bf9e8
to
4713700
Compare
Good idea! Adding the test showed, that the fix will not apply when the tests run as part of the test server. ( Unfortunately, I could not get it running, even when adding the workspaces for this case. Any idea why? |
I think we could merge this fix as-is (as it is a very significant issue) and add a todo to fix tests run from the dev server in future. Anthony & I already discussed potentially disabling that feature in future. |
4713700
to
1acfa43
Compare
thank you ❤️ |
Include tests without
.nuxt.
extension, by creating a workspace for the default environment🔗 Linked issue
Resolves #1296
❓ Type of change
📚 Description
Moving environmentMatchGlobs to define a workspace for the nuxt environment resulted in Vitest only running tests within that specific nuxt workspace, excluding tests from the parent/default configuration (from which the workspace inherits). Creating an additional workspace for the default, non-Nuxt environment ensured all tests were included again.