util: remove outdated TODO comment

[haramj]

Update deprecated() in lib/internal/util.js to check
getOptionValue('--no-deprecation') in addition to process.noDeprecation.

No test added yet. Suggested tests:

1. Warning suppressed when process.noDeprecation is true.
2. Warning suppressed when --no-deprecation CLI flag is set.
3. Warning emitted when neither flag is set.

Feedback on how to best add these tests is welcome.

TODO (joyeecheung): use getOptionValue('--no-deprecation') instead.
Would appreciate a review whenever you have time. Thanks!
/cc @joyeecheung

->

This PR only removes the TODO comment in lib/internal/util.js
that suggested replacing process.noDeprecation with
getOptionValue('--no-deprecation').

As noted in review, changing the behavior could break more than expected,
so we keep the current logic as-is and just clean up the comment.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (6428e2e) to head (f35aec5).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59760      +/-   ##
==========================================
- Coverage   89.95%   89.95%   -0.01%     
==========================================
  Files         667      667              
  Lines      196813   196812       -1     
  Branches    38425    38422       -3     
==========================================
- Hits       177038   177036       -2     
+ Misses      12200    12199       -1     
- Partials     7575     7577       +2     

Files with missing lines	Coverage Δ
lib/internal/util.js	96.17% <ø> (-0.01%)	⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joyeecheung]

I think at this point, I would prefer to just leave it as-is and just remove that TODO - I feel that changing it could otherwise break more than I expected, based on some simple GitHub searches.

[haramj]

I think at this point, I would prefer to just leave it as-is and just remove that TODO - I feel that changing it could otherwise break more than I expected, based on some simple GitHub searches.

I’ll update the PR to just remove the TODO comment.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69106/ 💚

[nodejs-github-bot]

Landed in 6478dd0...3837993