Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merton] Send through all payment details #5089

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dracos
Copy link
Member

@dracos dracos commented Jul 31, 2024

[skip changelog]
If we're confirming payment by an update (SLWP), store the payment as extra data on the update, so that it'll be sent through to the backend. Also store all payments, so for amendments the full history is sent through with the amended new booking.

If there has been an amendment, we want to include all payment
information when sending through to the backend.
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (2460d7d) to head (c7ddd5d).

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Merton.pm 80.00% 0 Missing and 1 partial ⚠️
perllib/FixMyStreet/Roles/Cobrand/BulkyWaste.pm 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5089   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         404      404           
  Lines       31462    31482   +20     
  Branches     4988     4991    +3     
=======================================
+ Hits        26008    26026   +18     
  Misses       3975     3975           
- Partials     1479     1481    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested a review from MorayMySoc August 1, 2024 10:32
Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants