-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merton] Send through all payment details #5089
Open
dracos
wants to merge
6
commits into
master
Choose a base branch
from
merton-payment-details-amending
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there has been an amendment, we want to include all payment information when sending through to the backend.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5089 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 404 404
Lines 31462 31482 +20
Branches 4988 4991 +3
=======================================
+ Hits 26008 26026 +18
Misses 3975 3975
- Partials 1479 1481 +2 ☔ View full report in Codecov by Sentry. |
MorayMySoc
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
dracos
force-pushed
the
merton-payment-details-amending
branch
from
August 14, 2024 15:48
f21aba2
to
c7ddd5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
If we're confirming payment by an update (SLWP), store the payment as extra data on the update, so that it'll be sent through to the backend. Also store all payments, so for amendments the full history is sent through with the amended new booking.