Add Linux VM support via Docker-based implementation #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
- Remove Windows-specific wording - Adjust Python path for cross-platform compatibility - Provide Docker-based Linux VM implementation - Update README with Linux setup instructions - Add graceful VM setup and cleanup procedures
dkohut
suggested changes
May 3, 2025
| mkdir -p "$HOME/.vnc/logs" | ||
|
|
||
| if [ $(uname -m) = "aarch64" ]; then | ||
| LD_PRELOAD=/lib/aarch64-linux-gnu/libgcc_s.so.1 vncserver :1 -fg -geometry 1920x1080 -depth 24" |
There was a problem hiding this comment.
There’s an extra double quote (") at the end of the command, that stray " causes the script to silently fail
| if [ $(uname -m) = "aarch64" ]; then | ||
| LD_PRELOAD=/lib/aarch64-linux-gnu/libgcc_s.so.1 vncserver :1 -fg -geometry 1920x1080 -depth 24" | ||
| else | ||
| vncserver :1 -fg -geometry 1920x1080 -depth 24" |
There was a problem hiding this comment.
another extra double quote (") at the end of the command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for running the project in a Linux VM environment by implementing a Docker-based solution. This extends platform support beyond the previous implementation and makes the project more accessible to Linux users.
Once a Linux VM is created and/or started, Omnibox is able to talk to it.
Example
Changes
Added Docker-based implementation for running in a Linux VM
Updated README with Linux VM setup and usage instructions
Modified scripts to work with the Linux environment
Removed Windows-specific wording from documentation
Adjusted Python path references to be platform-agnostic
Motivation
Original project assumes Win11 only. This implementation provides a standardized environment using Docker that ensures a working Linux VM is available and receives the commands sent by
omnitool.Documentation
The README has been updated with:
Setup instructions for Linux users
Docker configuration details
Command examples specific to the Linux environment
Screenshot