Skip to content

set a bin range to between filter in dashboard click behavior #59894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented Jun 20, 2025

closes #52861

Closes VIZ-269

Description

When clicking on a numeric value with binning that is connected via click behavior to between filter we want to set the bin range to the between filter.

How to verify

  • Question 1: Orders: Count by Total [Auto binned]
  • Create a dashboard, add Question 1 and any other question with a numeric dimension
  • Add a numeric parameter of type between and connect it to the other question
  • For Question 1 configure click behavior connecting it to the numeric parameter
  • Ensure clicking on Question 1 values sets the between numeric parameter range values, not just the first value

Demo

sets-range.mov

@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label Jun 20, 2025
@alxnddr alxnddr force-pushed the viz-269-set-correct-numeric-between-filter-on-binned-charts-clicks branch from b50a6b7 to 4ba4c23 Compare June 27, 2025 23:48
@alxnddr alxnddr requested a review from a team June 27, 2025 23:54
@alxnddr alxnddr added the backport Automatically create PR on current release branch on merge label Jun 27, 2025
@alxnddr alxnddr marked this pull request as ready for review June 27, 2025 23:54
Copy link
Contributor

e2e tests failed on 4ba4c23034c456c948312613d40acefeb9f251a6-1

e2e test run

File Test Name
reproductions.cy.spec.ts issue 58829 > should be able to use join native models when SQL column names do not match the names of the mapped fields (#58829)

@alxnddr alxnddr enabled auto-merge (squash) July 2, 2025 22:22
@alxnddr alxnddr merged commit 42aa1cc into master Jul 2, 2025
274 of 289 checks passed
@alxnddr alxnddr deleted the viz-269-set-correct-numeric-between-filter-on-binned-charts-clicks branch July 2, 2025 22:34
github-automation-metabase pushed a commit that referenced this pull request Jul 2, 2025
github-automation-metabase added a commit that referenced this pull request Jul 2, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
#60422)

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/DashViz Dashboard and Viz team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binned Data does not get passed to between filter
2 participants