Fix incorrect removal of braces in template macros #1278
Merged
+26
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with parsing the arguments of a macro with template where braces could be removed incorrectly. For example, with
\def\text#1\stop{#1}
, if used with\text{a}{b}\stop
, you currently will get an error about missing open braces. That is because the parameter#1
will end up containinga}{b
rather than{a}{b}
as expected.The solution is to set
hasBraces
to false when a second braced argument is used. I also changedhasBraces
to a boolean rather than a number.Two new tests are added to check for this issue. There should probably be some more tests for when
hasBraces
gets unset, for completeness.