Skip to content

Fix NoHostnameTlsVerifier for rustls 0.23.24 and above #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

elichai
Copy link
Contributor

@elichai elichai commented May 15, 2025

From Rustls 0.23.24 release:

New feature: More detailed and helpful error reporting for common certificate errors, such as name mismatches and certificate expiry. Users who std::fmt::Display the rustls Error type will take advantage of this automatically. Users handling CertificateError variants individually should note the new variants, such as CertificateError::NotValidForNameContext (compare CertificateError::NotValidForName).

This fixes the NoHostnameTlsVerifier by also matching on this new variant.

Fixes #3793

@abonander
Copy link
Collaborator

@elichai can you rebase, please? I think I fixed the error by generating new certificates in #3914.

Verified

This commit was signed with the committer’s verified signature.
elichai Elichai Turkel
@elichai
Copy link
Contributor Author

elichai commented Jul 1, 2025

@elichai can you rebase, please? I think I fixed the error by generating new certificates in #3914.

Done :)

@abonander abonander merged commit 2970559 into launchbadge:main Jul 2, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoHostnameTlsVerifier does not work with rustls v0.23.24 or later
2 participants