Add idempotence tests#1536
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b40741b to
3aa25bd
Compare
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 30, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-infra-cherrypick-robot
pushed a commit
to k8s-infra-cherrypick-robot/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-infra-cherrypick-robot
pushed a commit
to k8s-infra-cherrypick-robot/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> (cherry picked from commit a97b118)
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> (cherry picked from commit a97b118) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> (cherry picked from commit a97b118)
6cf605b to
8ab77e2
Compare
saschagrunert
added a commit
to saschagrunert/containerd
that referenced
this pull request
Jul 31, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> (cherry picked from commit a97b118) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
8ab77e2 to
2bb3732
Compare
Member
Author
|
Green CI. PTAL @kubernetes-sigs/cri-tools-maintainers |
Contributor
|
great addition! |
dbro86
pushed a commit
to dbro86/containerd
that referenced
this pull request
Aug 16, 2024
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding tests for RPC idempotence. Right now all runtimes fail them in various cases.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Needs:
StopPodSandboxRPC idempotent containerd/containerd#10520StopContainerRPC idempotent containerd/containerd#10521Does this PR introduce a user-facing change?