Skip to content

fix/datadog-scaler-null-last-point #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zroubalik merged 16 commits into from
Dec 8, 2022
Merged

fix/datadog-scaler-null-last-point #3954

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7d17261
fix/datadog-scaler-null-last-point
dogzzdogzz Dec 5, 2022
0c5a9b0
check point's length
dogzzdogzz Dec 5, 2022
ea9fca1
sort changelog alphabetically
dogzzdogzz Dec 5, 2022
1cb1d06
add unit test
dogzzdogzz Dec 5, 2022
8fb0d68
remove redudant code
dogzzdogzz Dec 5, 2022
894966f
update change log comment
dogzzdogzz Dec 5, 2022
db9293c
add newline
dogzzdogzz Dec 5, 2022
36979e4
Merge branch 'main' into fix/datadog-scaler-null-last-point
tonylee-shopback Dec 8, 2022
6ddddcd
rename the iterator
dogzzdogzz Dec 8, 2022
f862d0f
feature/datadog-scaler-timeWindowOffset-and-timeWindowOffset (#1)
dogzzdogzz Dec 8, 2022
392afae
remove comment
dogzzdogzz Dec 8, 2022
97dc26a
fix static check err
dogzzdogzz Dec 8, 2022
f14fbee
fix static check err
dogzzdogzz Dec 8, 2022
1559e6d
fix static check err
dogzzdogzz Dec 8, 2022
fce4899
exclude datadog_scaler.go from static check
dogzzdogzz Dec 8, 2022
9a0f9e1
Merge branch 'main' into fix/datadog-scaler-null-last-point
zroubalik Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redudant code 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
  • Loading branch information
@dogzzdogzz
dogzzdogzz committed Dec 5, 2022
commit 8fb0d6845cce81792b380f1dd00d10dfd6d77bc2
5 changes: 2 additions & 3 deletions pkg/scalers/datadog_scaler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@ var testParseQueries = []datadogQueries{

// Missing filter
{"min:system.cpu.user", false, true},
{"avg:system.cpu.user{*}.rollup(sum, 30),sum:system.cpu.user{*}.rollup(30)", true, false},
// #3448 Find out last point != nil
{"sum:trace.express.request.hits{*}.as_rate()/avg:kubernetes.cpu.requests{*}.rollup(10)", true, false}
// #3448 Find out last point != nil
{"sum:trace.express.request.hits{*}.as_rate()/avg:kubernetes.cpu.requests{*}.rollup(10)", true, false},
}

func TestDatadogScalerParseQueries(t *testing.T) {
Expand Down