Add tests for invalid and uncommon filter literal values#89
Merged
Conversation
f4067cd to
6b6acd3
Compare
gregsdennis
reviewed
Aug 2, 2024
gregsdennis
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I think it needs a few more cases.
Thanks for the work.
gregsdennis
reviewed
Aug 3, 2024
1 task
f3ath
approved these changes
Aug 3, 2024
f3ath
left a comment
Collaborator
There was a problem hiding this comment.
Very nice. Revealed a few issues in my implementation.
gregsdennis
approved these changes
Aug 3, 2024
This was referenced Aug 4, 2024
|
Why treat |
Contributor
Author
Similar to #90 (comment), because that is how it is defined in the JSONPath standard: A leading (This is also consistent with how JSON numbers are defined in the JSON specification.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally for number literals since JSONPath uses the same syntax as JSON, test values from regular JSON libraries or JSON test suites could be used, for example https://github.com/nst/JSONTestSuite.
So if you have anything else in mind which should be covered, please let me know or feel free to add it yourself.