Skip to content

Demos: fix easing demos #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Demos: fix easing demos #2320

merged 1 commit into from
Dec 18, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Dec 18, 2024 •
edited
Loading

I stumbled across this during CSP testing. https://jqueryui.com/easing/

  • Skip _default, which is a string and breaks the loop early
  • Adjust text styling so the easing names fit.

Old

image

New

image

@timmywil timmywil requested a review from mgol December 18, 2024 03:30
mgol
mgol approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmywil timmywil merged commit 0be13b5 into jquery:main Dec 18, 2024
11 checks passed
@timmywil timmywil deleted the easing branch December 18, 2024 15:14
@mgol mgol added this to the 1.14.2 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
Comp: Demos Comp: Effects
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@timmywil @mgol