-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(messaging, android): Add check for expo-notifications notification icon configurations #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
@mikehardy this is a fix for if you use |
Description
When using
expo-notifications
in combination with@react-native-firebase/messaging
for things like scheduling notifications now and otherexpo-notifications
features we ran into an issue where the config wasn't being set in the recommended plugins approach in their docs. This meant some android devices didn't have a notification icon - e.g. like this issue here expo/expo#24844The goal of this is to add a check for
expo-notifications
plugin and uses the configuration for notification icon and color. If there is also anotification.icon
andnotification.color
set then we will override with these values from the plugin.Related issues
As mentioned above we saw similar behaviour to this expo/expo#24844 with mentions of this library. But we still had the problem.
Release Summary
Adds a check for
expo-notifications
plugin and uses the configuration for notification icon and color ifnotification.icon
andnoticiation.color
doesn't already exist respectivelyChecklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter