Skip to content

fix(app-check, expo): init app-check shared instance before firebase in plugin #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

jsg2021
Copy link
Contributor

@jsg2021 jsg2021 commented Jun 8, 2025

Description

This resolves an issue where AppCheck does not work in iOS simulators even when following the documentation around ReactNativeFirebaseAppCheckProvider

Related issues

#6934
#6184

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Siteproxy
Copy link

vercel bot commented Jun 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2025 6:50am

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2025

CLA assistant check
All committers have signed the CLA.

@jsg2021 jsg2021 changed the title fix sharedInstance init order for iOS simulator to function fix: sharedInstance init order for iOS simulator to function Jun 8, 2025
@jsg2021 jsg2021 changed the title fix: sharedInstance init order for iOS simulator to function fix sharedInstance init order for iOS simulator to function Jun 8, 2025

Verified

This commit was signed with the committer’s verified signature.
jsg2021 Jonathan Grimes
This fixes the initialization order of the sharedInstance in the
AppDelegate for iOS. Leading to simulators not properly able to
setup the debug AppChcek provider.
@jsg2021 jsg2021 changed the title fix sharedInstance init order for iOS simulator to function fix: swift sharedInstance init order Jun 8, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh of course! Wish I had noticed that with the plugin - you definitely need to init the RNFBAppCheckModule instance prior to calling FirebaseApp, so this change makes sense. Thanks for catching + fixing this for Expo users

@mikehardy mikehardy changed the title fix: swift sharedInstance init order fix(app-check, expo): init app-check shared instance before firebase in plugin Jun 30, 2025
@mikehardy mikehardy merged commit f0a0292 into invertase:main Jun 30, 2025
15 of 18 checks passed
@jsg2021 jsg2021 deleted the patch-1 branch June 30, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants