-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(firestore): type definitions #8378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8378 +/- ##
==========================================
- Coverage 71.78% 69.79% -1.99%
==========================================
Files 163 187 +24
Lines 6626 8039 +1413
Branches 1524 1840 +316
==========================================
+ Hits 4756 5610 +854
- Misses 1749 2238 +489
- Partials 121 191 +70 🚀 New features to boost your workflow:
|
Kept definition for onSnapshotsInSync() which will merge with other PR that actually implements it. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look ready to go in, with exception of a question about the empty VectorValue.d.ts file - should that exist, or should it be deleted before mergin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an empty file in here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it, I think that was the right call?
ee9af2b
to
13411a2
Compare
@russellwheatley / @MichaelVerdon I rebased this to main and pushed it out, minus the empty modular/VectorValue.d.ts file - I think this is ready to go though ? +1 from me for merge anyway. Any last thoughts from you two no this one? |
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter