[ui] Adds meta k/v tables to Task Group and Task pages #24594
Conversation
438f37d to
5902561
Compare
4e1bb21 to
2f5069a
Compare
54c2ad0 to
3c49a56
Compare
3c49a56 to
935d000
Compare
| @@ -60,6 +60,8 @@ export default create({ | |||
| clientSource: text('[data-test-volume-client-source]'), | |||
| }), | |||
|
|
|||
| hasMeta: isPresent('[data-test-meta]'), | |||
There was a problem hiding this comment.
These are "test pages": a way to have nice syntactic sugar in our actual tests (like assert.ok(task.hasMeta)) instead of making the tests themselves feel verbose.
|
|
||
| if (task.withMeta) { | ||
| task.update({ meta: { raw: { foo: 'bar' } } }); | ||
| } |
There was a problem hiding this comment.
This is a factory file! Used by our mocking service (Mirage), and our tests, this gives us some private convenience methods when creating mocked objects like tasks/task groups. In this case, applying withTaskMeta to a task group will make a group with as many allocations/tasks as you'd like, each of which having some basic metadata.
| @@ -22,7 +22,7 @@ | |||
| PlacementFailures=(component "job-page/parts/placement-failures" job=@job) | |||
| TaskGroups=(component "job-page/parts/task-groups" job=@job) | |||
| RecentAllocations=(component "job-page/parts/recent-allocations" job=@job activeTask=@activeTask setActiveTaskQueryParam=@setActiveTaskQueryParam) | |||
| Meta=(component "job-page/parts/meta" job=@job) | |||
| Meta=(component "job-page/parts/meta" meta=@job.meta) | |||
There was a problem hiding this comment.
This generally changes the context from "This is a component for jobs, it knows how to get metadata from a job" to "This is a component for metadata, it is given metadata"
| get mergedMeta() { | ||
| return { | ||
| ...this.taskGroup.mergedMeta, | ||
| ...this.meta, | ||
| ...this.meta?.raw, |
There was a problem hiding this comment.
You might notice that this is using the ...this.meta.raw format where the above task-group model is using this.get('meta.raw'). The get syntax is valid JS and everything, but is more of an old-ember convention, and task group models have existed longer than task models in our codebase.
You can see these old-ember ways of doing things scattered throughout: look for a @classic decorator near the top of the class declaration.
01675ae to
1fb8c7e
Compare
Description
In addition to
job.meta,job.taskGroups[].metaandjob.taskGroups[].tasks[].metablocks are valid jobspec blocks (docs)This PR adds tables to show their key/values on relevant gruop and task pages that have them. This uses the same table that is otherwise shown on job index pages (or parameterized/periodic job dispatches).
Testing & Reproduction steps
Add a
metablock with some entries to one your jobs' taskGroups and tasks, and navigate to those in the web UI.Resolves #24345